fix(blog): ui improvements and comment layout fix#2139
fix(blog): ui improvements and comment layout fix#2139ghostdevv merged 12 commits intonpmx-dev:mainfrom
Conversation
…-dev#2136, npmx-dev#2137) Redesign nested comments to use a flat, single-indent layout with collapsible reply threads. Fix blog content alignment, button hover states, Bluesky embed icon positioning, prose link hover effects, and federated articles shadow/alignment.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis pull request updates multiple blog-related Vue components and i18n locale files. Component changes adjust responsive layouts, avatar rendering and alignment, spacing in comment and post elements, nested-replies indentation, and Bluesky embed positioning and hover behaviour (BlueskyComment.vue, BlogPostFederatedArticles.vue, BlogPostWrapper.vue, BlueskyPostEmbed.client.vue). Ten locale files (az-AZ, cs-CZ, de-DE, fr-FR, id-ID, ja-JP, pl-PL, ru-RU, tr-TR, zh-CN) have revised wording and pluralisation for the blog.atproto.more_replies key. Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
app/components/BlueskyCommentThread.vue (1)
38-38: Consider Vue 3.4+ same-name shorthand.Since you're using Vue 3.5.30, you can simplify the binding using the same-name shorthand.
♻️ Suggested refactor
- <BlueskyComment :comment="comment" /> + <BlueskyComment :comment />Based on learnings: "In Vue 3.4 and later, you can use same-name shorthand for attribute bindings: use :attributeName instead of :attributeName="attributeName" when binding to a variable with the same name in scope."
app/components/BlueskyComment.vue (1)
72-72: Remove the non-essential template comment at Line 72.
<!-- Replying to label -->is describing obvious markup and can be dropped to keep the template lean.As per coding guidelines, “Add comments only to explain complex logic or non-obvious implementations.”
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f8d84945-1caf-45be-ac18-ac342f8d79f9
📒 Files selected for processing (9)
app/components/BlueskyComment.vueapp/components/BlueskyCommentThread.vueapp/components/BlueskyComments.vueapp/components/Link/Base.vueapp/components/global/BlogPostFederatedArticles.vueapp/components/global/BlogPostWrapper.vueapp/components/global/BlueskyPostEmbed.client.vuei18n/locales/en.jsoni18n/schema.json
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 09bb1c82-0f32-4848-a2d7-06cc7d3bcfde
📒 Files selected for processing (16)
i18n/locales/az-AZ.jsoni18n/locales/cs-CZ.jsoni18n/locales/de-DE.jsoni18n/locales/en.jsoni18n/locales/es.jsoni18n/locales/fr-FR.jsoni18n/locales/id-ID.jsoni18n/locales/ja-JP.jsoni18n/locales/pl-PL.jsoni18n/locales/pt-BR.jsoni18n/locales/ru-RU.jsoni18n/locales/tr-TR.jsoni18n/locales/uk-UA.jsoni18n/locales/zh-CN.jsoni18n/schema.jsontest/unit/a11y-component-coverage.spec.ts
✅ Files skipped from review due to trivial changes (1)
- i18n/locales/uk-UA.json
🚧 Files skipped from review as they are similar to previous changes (2)
- i18n/locales/en.json
- i18n/schema.json
Nested comments use inline avatar on mobile (Medium-style) for full content width, and classic avatar-column on desktop. Each nesting level costs ~12px on mobile instead of ~44px, eliminating horizontal scroll. Removes BlueskyCommentThread in favor of recursive depth.
- Use hover:shadow-fg/5 for federated articles shadow - Scope prose link hover to exclude no-underline links - Add group hover for Bluesky icon (blue on card hover) - Revert button-primary hover to original accent style - Use separate class/v-bind for avatar shrink-0 - Fix pt-BR duplicate JSON keys from merge conflict
Handles unicode characters made up of multiple code points correctly.
|
Looks like the comments have been addressed! We can do a follow up if we missed anything 🙏 |
Summary
Closes #2136, closes #2137